-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ameba] Use wifi info in persistentstorage for reconnection after reboot #18661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
May 20, 2022 10:51
pullapprove
bot
requested review from
woody-apple,
xylophone21 and
yunhanw-google
May 20, 2022 10:51
PR #18661: Size comparison from d346617 to 009d628 Full report (32 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
/rebase |
pankore
force-pushed
the
connectivity_update
branch
from
May 23, 2022 02:16
009d628
to
6131c12
Compare
PR #18661: Size comparison from 7afd352 to 6ee1798 Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
May 24, 2022
- Add chip-failsafe, chip-sessionresumptionindex, chip-sessionresumption - Remove chip-dns
- Add chip-deviceinfoprovider
…ter reboot * Implement AmebaUtils for wifi helper functions * Update ConnectivityManagerImpl and NetworkCommissioningDriverWiFi to use AmebaUtils functions * Add ChipGroupMessageCounters, ChipOthers2 * Remove ChipSessionResumptionIndex, which will be part of ChipOthers
* Add OTAHelper to initiate ota requestor from DeviceCallback * Edit ConnectivityManager to allow link local IPv6 addresses
pankore
force-pushed
the
connectivity_update
branch
from
May 27, 2022 02:13
689a535
to
9f44742
Compare
PR #18661: Size comparison from e7bb258 to 9f44742 Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
/rebase |
Hi @andy31415 , |
andy31415
reviewed
May 31, 2022
BDXDownloader gDownloader; | ||
AmebaOTAImageProcessor gImageProcessor; | ||
chip::ota::DefaultOTARequestorUserConsent gUserConsentProvider; | ||
static chip::ota::UserConsentState gUserConsentState = chip::ota::UserConsentState::kGranted; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: anonymous namespace does not need static.
andy31415
approved these changes
May 31, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Jun 2, 2022
…oot (project-chip#18661) * [PersistentStorage] Update DCT domains - Add chip-failsafe, chip-sessionresumptionindex, chip-sessionresumption - Remove chip-dns * [PersistentStorage] Update DCT domains - Add chip-deviceinfoprovider * [Connectivity] Use persistent storage wifi info to connect to wifi after reboot * Implement AmebaUtils for wifi helper functions * Update ConnectivityManagerImpl and NetworkCommissioningDriverWiFi to use AmebaUtils functions * Add ChipGroupMessageCounters, ChipOthers2 * Remove ChipSessionResumptionIndex, which will be part of ChipOthers * [OTA] Initiate OTA requestor after getting IPv6 * Add OTAHelper to initiate ota requestor from DeviceCallback * Edit ConnectivityManager to allow link local IPv6 addresses * [Connectivity] Use AmebaUtils function in NetworkCommissioningWiFiDriver * Restyled by whitespace * Restyled by clang-format * [Connectivity] Rename OTAHelper to OTAInitializer Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing